Conversation
🦋 Changeset detectedLatest commit: 6c34fa1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikospapcom
changed the title
ConnectedAccountsMenu.tsx when authenticatable is falseConnectedAccountsMenu.tsx
nikospapcom
force-pushed
the
nikospap/fix-undefined-properties-in-connected-accounts-menu
branch
2 times, most recently
from
d2ea385 to
1271dbc
Compare
octoper
reviewed
Aug 24, 2024
…nu.tsx` when authenticatable is false
nikospapcom
force-pushed
the
nikospap/fix-undefined-properties-in-connected-accounts-menu
branch
from
1271dbc to
6c34fa1
Compare
LekoArts
approved these changes
Aug 26, 2024
panteliselef
approved these changes
Aug 26, 2024
LekoArts
deleted the
nikospap/fix-undefined-properties-in-connected-accounts-menu
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this pr we are fixing undefined properties error in
ConnectedAccountsMenu.tsxwhen Custom OAuth Provider isactiveandauthenticatableisfalseThe error was:
The bug was that we populated the
strategyToDisplayDatawithauthenticatableinstead ofactiveCustom OAuth Providers.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change